Disable webhook firing if disable in configuration (13) #18383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeegaan
deleted the
v13/bugfix/allow-disable-of-webhook-scheduled-job
branch
|
@piotrbach @wtct - FYI (and thanks for your blog post that passed my way so that we noticed this). |
|
Hi @AndyButland, big thanks for the update! Awesome & glad to hear the blog post was useful🚀 |
AndyButland
added a commit
that referenced
this pull request
Feb 19, 2025
AndyButland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Issue discussed here:
https://umbracare.net/blog/disabling-webhooks-for-maximum-performance-in-umbraco
Description
I saw this blog post go by in Umb-FYI and seemed to me it was providing a workaround that shouldn't be necessary.
So I've disabled the firing of webhooks if webhooks are disabled in configuration, as I believe that should be what is happening.
To Test:
WebhookFiringjob and verify that it doesn't run.