Tiptap RTE: Reusable toolbar menu component #18483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a reusable menu component. Removes the `unique` property for menu-items.
iOvergaard
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
LGTM but there are merge conflicts after the other tiptap PR was merged. Will you have a look at that, @leekelleher?
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/manifests.ts # src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/tiptap-toolbar.extension.ts
|
@iOvergaard I didn't mean to re-request a review! 🤦 I've resolved the merge conflict now. 😀 |
iOvergaard
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After PRs #18364, #18365 and #18443, I'd noticed code duplication. I have abstracted these out to a reusable Tiptap toolbar menu component, where a menu can be defined in the manifest and a corresponding API can handle the click/
execute()method.Also, I picked up on a couple of other Tiptap snags, they were quite minor, so I've bundled them in this PR.
How to test?
If using the mock data, then go to the "All RTEs" page, (if using the server, enable the toolbar buttons for the Tiptap RTE and go to a corresponding page). Then test that the Font Family, Font Size, Style Select and Table toolbar buttons work as expected.