Correct handling of step values of zero #18532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
added a commit
that referenced
this pull request
Mar 4, 2025
|
I've cherry-picked this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: #18528
Description
The linked issue highlights a problem with the property step validation we've added, which will fail if the step is zero due to a divide by zero error.
I've resolved this by always passing validation if the step is zero (which avoids the error, and is also correct as any value is valid for a zero step).
To test, see the tests, and manually see the replication steps on the issue.
Should be cherry-picked to the release branch once merged.