Skip to content

V15: Enable umbraco-extension client to auto-build #18597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 11, 2025

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Mar 6, 2025

Description

The big change here is to allow the client to automatically build its files if they have changed since the last build. This is code taken from the Backoffice RCL included with Umbraco, which works by adding a few targets to the .csproj file to restore npm and run vite build.

Changes

  • Updates all of the dependencies to the latest
  • Adds targets to the csproj file to allow the Client code to auto-build

How to test

It's a little complicated to test, but essentially you need to pack the whole solution and add the template manually approx. like so:

dotnet pack -o ../artifacts
dotnet new uninstall Umbraco.Templates
dotnet new install ../artifacts/Umbraco.Templates.*

Following that, you need to spin up an Umbraco solution and add the template to it:

mkdir MyTest
cd MyTest
dotnet new umbraco -n MyTest.Web
dotnet new sln
dotnet new umbraco-extension -n MyTest.Client -ex
dotnet sln add MyTest.Client
dotnet add MyTest.Web/MyTest.Web.csproj reference MyTest.Client/MyTest.Client.csproj

Then run the site:

dotnet run --project MyTest.Web

Now verify that the site can build and the examples are working.

@iOvergaard iOvergaard marked this pull request as ready for review March 6, 2025 16:02
iOvergaard and others added 3 commits March 11, 2025 13:16
- Adds `BeforeTargets` to "BuildClient" target
- Adds "package.json" to "RestoreClient" target input
- Removes extra parameters from `npm i` command
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some pair programming, tested out and it works as expected. 🚀

@leekelleher leekelleher enabled auto-merge (squash) March 11, 2025 15:40
@leekelleher leekelleher merged commit df6a88b into v15/dev Mar 11, 2025
20 of 21 checks passed
@leekelleher leekelleher deleted the v15/feature/dotnet-extension-autobuild branch March 11, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants