-
Notifications
You must be signed in to change notification settings - Fork 2.8k
V15: Enable umbraco-extension client to auto-build #18597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat it is actually called
…-extension-autobuild
- Adds `BeforeTargets` to "BuildClient" target - Adds "package.json" to "RestoreClient" target input - Removes extra parameters from `npm i` command
leekelleher
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some pair programming, tested out and it works as expected. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The big change here is to allow the client to automatically build its files if they have changed since the last build. This is code taken from the Backoffice RCL included with Umbraco, which works by adding a few targets to the .csproj file to restore npm and run
vite build
.Changes
How to test
It's a little complicated to test, but essentially you need to pack the whole solution and add the template manually approx. like so:
dotnet pack -o ../artifacts dotnet new uninstall Umbraco.Templates dotnet new install ../artifacts/Umbraco.Templates.*
Following that, you need to spin up an Umbraco solution and add the template to it:
mkdir MyTest cd MyTest dotnet new umbraco -n MyTest.Web dotnet new sln dotnet new umbraco-extension -n MyTest.Client -ex dotnet sln add MyTest.Client dotnet add MyTest.Web/MyTest.Web.csproj reference MyTest.Client/MyTest.Client.csproj
Then run the site:
Now verify that the site can build and the examples are working.