Avoids unnecessary additional domain save notification publishing when sorting an already sorted collection of domains #19106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en sorting an already sorted collection of domains.
AndyButland
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR aims to prevent unnecessary notifications when the domains collection is already sorted, avoiding duplicate domain save notifications when no sorting is required.
- Conditionally short-circuiting notification publishing if the domains array is empty or already sorted
- Introducing the AreDomainsAlreadySorted helper method to assess the sort order of domains
nikolajlauridsen
approved these changes
May 14, 2025
nikolajlauridsen
deleted the
v13/bugfix/avoid-unnecessary-domain-save-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves: #19104
Description
The behaviour described in the linked issue occurs due to two operations being requested on the domains collection:
In most cases, we aren't sorting as well as saving, so we can short-circuit and not publish the second notification when we aren't making any changes to sort order.
When we are sorting, it's strictly correct to publish two notifications as we are making two separate saves.