Retrofit ContentEditingBaseBuilder to match new create/update models #19129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
#19114 changed the create/update models in the content editing service layers (documents, media, members).
This is a follow-up to fix a task that was consciously omitted from #19114 - make the test utility
ContentEditingBaseBuilderconform to the new models.Breaking change?
This is definitively also breaking change like #19114 was. Fortunately, this PR limits the breakage to the test projects.
If you're affected by this breakage, you should be able to retrofit your tests in the same way as the core tests have been by this PR.
Testing this PR
This PR solely targets integration tests and test utilities, so... if the tests pass, all is good 👍