Skip to content

V16 RC: Add more debug info to System Information #19343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented May 16, 2025

Description

  • Rearrange sysinfo debug for a better overview
  • See if we can pull in the client version directly from the package.json to verify against the server version
  • Adds information directly from the TemporaryFileConfiguration repository such as allowed/disallowed upload types and file max size
  • Fixes a small UI issue where #code-block and #codeblock were used intermittently in the CSS

Before:
image

After:
image

Example output:

Umbraco system information
--------------------------------
Server Troubleshooting: 
Server OS: Darwin 24.4.0 Darwin Kernel Version 24.4.0: Fri Apr 11 18:33:47 PDT 2025; root:xnu-11417.101.15~117/RELEASE_ARM64_T6000
Server Framework: .NET 9.0.2
Default Language: en-US
Umbraco Version: 16.1.0-rc.preview.21
Current Culture: en-US
Current UI Culture: en-US
Current Webserver: Kestrel
Models Builder Mode: InMemoryAuto
Runtime Mode: BackofficeDevelopment
Debug Mode: True
Database Provider: System.Data.SQLite
Current Server Role: Single

Server Information: 
Umbraco build version: 16.1.0-rc.preview.21+ceab77d
Umbraco assembly version: 16.1.0-rc.preview.21
Server time offset: 01:00:00
Runtime mode: BackofficeDevelopment

Client Information: 
Umbraco client version: 16.0.0-rc

Current user: 
User is admin: Yes
User sections: Umb.Section.Content, Umb.Section.Forms, Umb.Section.Media, Umb.Section.Members, Umb.Section.Packages, Umb.Section.Settings, Umb.Section.Translation, Umb.Section.Users
User culture: en-US
User languages: All
User document start nodes: 

Temporary file configuration: 
Max allowed file size: Not set (unlimited)
Allowed file types: 
Disallowed file types: ashx, aspx, ascx, config, cshtml, vbhtml, asmx, air, axd, xamlx, html
Image file types: png, apng, jpg, jpeg, jfif, gif, bm, bmp, dip, ppm, pbm, pgm, tga, vda, icb, vst, tiff, tif, webp, qoi

Browser Troubleshooting: 
Browser (user agent): Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36
Browser language: en-US
Browser location: http://localhost:5173/section/media/workspace/media/create/parent/media-root/null/4c52d8ab-54e6-40cd-999c-7a5f24903e4d/invariant/root

@Copilot Copilot AI review requested due to automatic review settings May 16, 2025 13:33
@iOvergaard iOvergaard requested a review from leekelleher May 16, 2025 13:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds enhanced debug information to the System Information panel by rearranging existing sections and including new data such as client version (from package.json) and temporary file configuration details.

  • Added a new repository method to fetch client information.
  • Rearranged and extended the sysinfo display to include client info and temporary file configuration.
  • Modified temporary file configuration data retrieval to disable notifications.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/Umbraco.Web.UI.Client/src/packages/sysinfo/repository/sysinfo.repository.ts Introduces a method to extract client version from package.json.
src/Umbraco.Web.UI.Client/src/packages/sysinfo/components/sysinfo.element.ts Reorders and adds sections (Client Information, Temporary file configuration, Browser Troubleshooting) and updates element IDs.
src/Umbraco.Web.UI.Client/src/packages/core/temporary-file/config/config.server.data-source.ts Updates configuration request to disable notifications.
src/Umbraco.Web.UI.Client/src/packages/core/temporary-file/config/config.repository.ts Refactors temporary file configuration retrieval and updates the datastore accordingly.
Comments suppressed due to low confidence (1)

src/Umbraco.Web.UI.Client/src/packages/sysinfo/components/sysinfo.element.ts:189

  • Changing the element ID from '#code-block' to '#codeblock' may affect styling if the old ID is referenced elsewhere; ensure that any such references are updated to maintain consistency.
#codeblock {

@leekelleher leekelleher merged commit 2c3af1b into release/16.0 May 19, 2025
23 checks passed
@leekelleher leekelleher deleted the v16/feature/more-client-information branch May 19, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants