Fix rare concurrency issue in back-office auth middleware #19418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
It is apparently possible to trigger a concurrency exception in the
BackOfficeAuthorizationInitializationMiddleware
.I have not been able to reproduce it, but here's a screenshot of the error (sent by a colleague):
This PR fixes it. I'm erring on the side of caution here, since the PR targets V16 RC. It could likely be solved in a different way using
ConcurrentBag<string>
instead ofHashSet<string>()
to store the known hosts, but since we still need to perform explicit locking to avoid duplicate updates of back-office hosts, I think this is an OK solution.Testing this PR
As mentioned, I can't reproduce the issue myself. So most of all, a visual inspection of the code is in order - and then a verification that the back-office still works 😆