V16: Upgrade Login dependencies to Umbraco 16 #19433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOvergaard
added
dependencies
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Umbraco login project to use Umbraco 16 dependencies, strengthens error handling guards in UI components, and brings consistent import formatting across the codebase.
- Bumped core dependencies in
package.jsonto align with Umbraco 16 (RC) and updated tooling versions. - Added fallback error handling for missing contexts and registration failures.
- Standardized import syntax and quote style in multiple TypeScript files.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Login/src/controllers/slim-backoffice-initializer.ts | Added a .catch() to extension registration and consolidated imports |
| src/Umbraco.Web.UI.Login/src/contexts/auth.repository.ts | Reordered/moved backoffice imports for consistency |
| src/Umbraco.Web.UI.Login/src/contexts/auth.context.ts | Standardized import quotes and removed redundant generic parameter |
| src/Umbraco.Web.UI.Login/src/components/pages/reset-password.page.element.ts | Standardized imports and added guard for missing authContext |
| src/Umbraco.Web.UI.Login/src/components/pages/login.page.element.ts | Updated supportPersistLogin assignment to use optional chaining |
| src/Umbraco.Web.UI.Login/src/components/layouts/new-password-layout.element.ts | Added guard for missing passwordConfiguration and standardized imports |
| src/Umbraco.Web.UI.Login/package.json | Upgraded @umbraco-cms/backoffice, @hey-api/openapi-ts, typescript, and vite |
src/Umbraco.Web.UI.Login/src/components/layouts/new-password-layout.element.ts
Outdated
Show resolved
Hide resolved
leekelleher
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
We can upgrade to a public Umbraco 16 RC version on the login screen because we only need to match the typings
This pull request introduces several updates to the
Umbraco.Web.UI.Loginproject, focusing on dependency upgrades, improved error handling, and code consistency. The most important changes include upgrading dependencies inpackage.json, enhancing error handling in various components, and improving code readability and consistency by updating imports and formatting.Dependency Upgrades:
@umbraco-cms/backofficeto version16.0.0-rc3,@hey-api/openapi-tsto^0.67.3,typescriptto^5.8.3, andviteto^6.3.5inpackage.jsonfor compatibility with the latest features and bug fixes.Error Handling Improvements:
authContextavailability inUmbNewPasswordLayoutElementandUmbResetPasswordPageElementto prevent potential runtime errors when the authentication context is unavailable. [1] [2]UmbSlimBackofficeControllerby adding acatchblock forregisterPublicExtensionsto gracefully handle errors during extension registration.Code Consistency and Cleanup:
reset-password.page.element.ts,auth.context.ts,auth.repository.ts,slim-backoffice-initializer.ts) by using single quotes and consistent ordering. [1] [2] [3] [4]