Update to go-pkgz/auth/v2 and golang-jwt/jwt/v5 #1758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8638476796Details
💛 - Coveralls |
paskal
force-pushed
the
paskal/jwt_v5
branch
2 times, most recently
from
81ba327 to
9f38749
Compare
Pull Request Test Coverage Report for Build 10192720403Details
💛 - Coveralls |
paskal
force-pushed
the
paskal/jwt_v5
branch
2 times, most recently
from
a1b6029 to
4ac60d0
Compare
umputun
reviewed
Dec 9, 2024
backend/app/rest/api/admin.go
Outdated
| @@ -107,13 +107,20 @@ func (a *admin) deleteMeRequestCtrl(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| if err = a.dataService.DeleteUserDetail(claims.Audience, claims.User.ID, engine.AllUserDetails); err != nil { | |||
| if len(claims.Audience) != 1 { | |||
| rest.SendErrorJSON(w, r, http.StatusBadRequest, fmt.Errorf("bad request"), "can't process token, aud is not a single element", rest.ErrActionRejected) | |||
There was a problem hiding this comment.
Probably changing the error message to indicate which element is expected to be single will be better.
paskal
force-pushed
the
paskal/jwt_v5
branch
from
161257b to
e61a46e
Compare
umputun
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also serve as a reference for go-pkgz/auth/v2 migration, and I'll add links to this PR to the readme for the auth package.