Update to Unicode 13 #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change version fields to u8 as the maximum value of each field is 255 according to specification.
pyfisch
commented
Apr 13, 2020
| UNICODE_VERSION = "9.0.0" | ||
| UCD_URL = "https://www.unicode.org/Public/%s/ucd/" % UNICODE_VERSION | ||
| UNICODE_VERSION = "13.0.0" | ||
| UCD_URL = "http://www.unicode.org/Public/%s/ucd/" % UNICODE_VERSION |
There was a problem hiding this comment.
I changed this to HTTP because https://www.unicode.org/foobar currently has a bad TLS certificate.
This is probably related to this note on their main page:
APRIL 10, 2020 TECHNICAL ALERT: the Unicode Consortium’s technical website is hosted in a data center that has experienced a catastrophic failure. We are working to get back online, but this may take a couple weeks. We apologize for the inconvenience.
There was a problem hiding this comment.
@Manishearth
Can be merged this PR as is?
With future tiny correction.
Manishearth
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change version fields to u8 as the maximum value
of each field is 255 according to specification.
See also rust-lang/rust#49726 (comment)
Is there a particular reason that this crate is currently depends on Unicode 9, four versions behind the latest release?