Skip to content

Tmain: initialize "V" variable explicitly #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

masatake
Copy link
Member

@masatake masatake commented Jun 8, 2018

"V" variable was introduced as a placeholder that is used when I want
to run the test case under valgrind; the valgrind command line is set
to "V".

It seems that "Ubuntu PPA build" environment defines V as an environment
variable with value "1". See #1761.

As the result, the test case doesn't work well on the environment.

This commit clears the value for "V" to allow the test case works
on the environment.

"V" variable was introduced as a placeholder that is used when I want
to run the test case under valgrind; the valgrind command line is set
to "V".

It seems that "Ubuntu PPA build" environment defines V as an environment
variable with value "1". See universal-ctags#1761.

As the result, the test case doesn't work well on the environment.

This commit clears the value for "V" to allow the test case works
on the environment.
@hnakamur
Copy link

hnakamur commented Jun 8, 2018

@masatake You are right. The failed build log contains the following:

User Environment
----------------

APT_CONFIG=/var/lib/sbuild/apt.conf
DEB_BUILD_OPTIONS=parallel=4
HOME=/sbuild-nonexistent
LANG=C.UTF-8
LC_ALL=C.UTF-8
LOGNAME=buildd
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
SCHROOT_ALIAS_NAME=build-PACKAGEBUILD-14993131
SCHROOT_CHROOT_NAME=build-PACKAGEBUILD-14993131
SCHROOT_COMMAND=env
SCHROOT_GID=2501
SCHROOT_GROUP=buildd
SCHROOT_SESSION_ID=build-PACKAGEBUILD-14993131
SCHROOT_UID=2001
SCHROOT_USER=buildd
SHELL=/bin/sh
TERM=unknown
USER=buildd
V=1

Thanks for this commit! I imported this commit as a patch
hnakamur/universal-ctags-deb@8fe33d9
and build succeeded.
The build log

@masatake
Copy link
Member Author

masatake commented Jun 8, 2018

Thank you for verifying.

@masatake masatake merged commit 44a0e97 into universal-ctags:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants