Make: fix wrong end fields for targets having macros on the same line #3931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <[email protected]>
For the input: # y: x = 1 ctags with the original code warns: ctags: Warning: given end line (1) for the tag (y) in the file (Makefile) is smaller than its start line: 2 Signed-off-by: Masatake YAMATO <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3931 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 234 234
Lines 56190 56199 +9
=======================================
+ Hits 47971 47980 +9
Misses 8219 8219 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the input:
y: x = 1
ctags with the original code warns:
ctags: Warning: given end line (1) for the tag (y) in the file (Makefile) is smaller than its start line: 2