main: report errors when calling ftell(3) fails #4012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4012 +/- ##
==========================================
- Coverage 85.43% 85.43% -0.01%
==========================================
Files 235 235
Lines 56723 56727 +4
==========================================
+ Hits 48460 48462 +2
- Misses 8263 8265 +2 ☔ View full report in Codecov by Sentry. |
k-takata
reviewed
Jun 5, 2024
| @@ -2335,6 +2340,10 @@ extern void setTagFilePosition (MIOPos *p, bool truncation) | |||
| if (truncation) | |||
| { | |||
| long t1 = mio_tell (TagFile.mio); | |||
| if (t1 == -1) | |||
| error (FATAL|PERROR, | |||
| "failed to tell the file position of the tag file (t0)\n"); | |||
There was a problem hiding this comment.
... I'm shame. Thank you very much.
masatake
added a commit
to masatake/ctags
that referenced
this pull request
Jun 5, 2024
Suggested by @k-takata on universal-ctags#4012.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is for debugging #4011. However, the change is generic.