Verilog: Fix function parse when return type contains ::

[roccomao]

This is a fix for #4109, and this TODO list (#2674) now can be checked:

• fixme in systemverilog-task-function.d/inputs.sv
  • function void foo::bar();
  • function foo #(IF) bar();

We should ignore any return type of a function. We only need to parse the class_scope before the function or task name.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.85%. Comparing base (b6d1cac) to head (68ef8d6).
Report is 8 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4111   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         239      239           
  Lines       58629    58652   +23     
=======================================
+ Hits        50333    50356   +23     
  Misses       8296     8296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[masatake]

Much easier to read!

[roccomao]

Aha! Thanks for your detailed review and guidance, it helped me a lot. 😄

[hirooih]

@roccomao,

Thanks a lot!
I will review your fix this evening.

[hirooih]

@roccomao,

Thank you for your great fix.
You also fix the bug of currentContext->virtual in dropContex().

I've added a note on your comment. Please fix it.

I still don't understand how getFirstClassNameIndex() works well. I may be able to simply it some more, but not sure yet. Let me some more time to think about it.

[roccomao]

At first, I just added as detailed a description and test cases as possible to submit an issue, hoping to help developers analyze the problem. Suddenly, I wanted to see how it was implemented. The clear implementation code structure makes it understandable to newbies, so I raised this PR and received detailed review and guidance. Thanks a lot!

You also fix the bug of currentContext->virtual in dropContex().

This is mentioned in 6de290bc detailed commit messages.

I still don't understand how getFirstClassNameIndex() works well. I may be able to simply it some more, but not sure yet. Let me some more time to think about it.

In fact, we only add the class scope to the token before ::, and :: can only appear before the return type and function name. So how to separate the return type and function name? If they both contain ::, then there are at least two adjacent tokens between the two :: that is exactly the split point. This is my implementation idea.

[roccomao]

Comments and test cases were updated.

[roccomao]

Refer to PR #4116, the class now supports final_specifier. Similarly, the class method now supports dynamic_override_specifiers. The current implementation of this PR is actually unaffected. Anyway, let's update the comments again and add a few test cases.

latest IEEE Std 1800-2023 8.3 Syntax:

dynamic_override_specifiers ::= [ initial_or_extends_specifier ] [ final_specifier ]
    initial_or_extends_specifier ::= : initial | : extends
    final_specifier ::= : final

In addition, the implementation of the getFirstClassNameIndex function was refactored.

[hirooih]

Again thank you very much for your great work!

[roccomao]

Fixed #4109

❤️ Many Thanks to the reviewers, you helped me a lot. Now let's close the associated issue.