main: various minor improvements, especially about mio #4214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
The original code returned a dummy MIOPos made with memset(&pos, 0, sizeof (pos)) if the lineFposMap is not ready. The dummy MIOPos doesn't work if MIO_DEBUG is enabled. Signed-off-by: Masatake YAMATO <[email protected]>
…rind In makePatternStringCommon, we compare memory patterns of MIOPos objects in an abusive way. As the result, uninitialized union members and holes in MIOPos are accessed. Valgrind detects the accesses and reports errors. Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4214 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 241 241
Lines 62525 62535 +10
=======================================
+ Hits 53675 53684 +9
- Misses 8850 8851 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
781da3f triggers many bugs. I will revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for #4212.