Moose: stop parsing when the base parser stops parsing #4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed universal-ctags#4217 When Perl parser finds __END__ in the input, it stops parsing. As a result, inputEnd method of Moose parser is called. However. the original code doesn't stop parsing after called the method. The inputEnd method of Moose parser did only release its resources (supersOrRoles member). Moose parser continued parsing the text after __END__ and accessed the supersOrRoles member. ctags crashed here. Signed-off-by: Masatake YAMATO <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4218 +/- ##
=======================================
Coverage 85.80% 85.80%
=======================================
Files 241 241
Lines 62536 62537 +1
=======================================
+ Hits 53660 53661 +1
Misses 8876 8876 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4217
When Perl parser finds
__END__in the input, it stops parsing. As a result, inputEnd method of Moose parser is called.However. the original code doesn't stop parsing after called the method. The inputEnd method of Moose parser did only release its resources (supersOrRoles member).
Moose parser continued parsing the text after
__END__and accessed the supersOrRoles member. ctags crashed here.