Immutable: Removed useless call to .Equals() in .ToImmutable() + misc #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a non-readonly, non-static field was used, the codegen was crashing when trying to report this error situation.
This was preventing the creation of an instance when the set fields was ignored in the equality check.
carldebilly
force-pushed
the
dev/cdb/bug-error-reporting
branch
from
3cff77e to
f7ad5f8
Compare
dr1rrb
approved these changes
Oct 22, 2018
MatFillion
approved these changes
Oct 22, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Equals()in.ToImmutable(), preventing the creation of an instance when the set fields was ignored in the equality check..Defaultis not a readonly property