Skip to content

Docker support #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025
Merged

Docker support #6

merged 5 commits into from
Apr 3, 2025

Conversation

ytkimirti
Copy link
Contributor

No description provided.

Copy link

linear bot commented Apr 1, 2025

@yunusemreozdemir
Copy link
Contributor

A general question, after running the smithery setup command for claude, it adds the mcp server to the config with the name mcp-server. Is this the default behaviour or could we change this name? What happens if someone tries to set up the mcp server and this name already exists in the config?

@yunusemreozdemir
Copy link
Contributor

When I build the image I get these warnings, can you check them and confirm they are not a problem:

 2 warnings found (use docker --debug to expand):
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "UPSTASH_API_KEY") (line 34)
 - JSONArgsRecommended: JSON arguments recommended for ENTRYPOINT to prevent unintended behavior related to OS signals (line 40)

@ytkimirti ytkimirti merged commit 3fbaac7 into main Apr 3, 2025
@ytkimirti ytkimirti mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants