Skip to content

chore: update pallet-revive in e2e crate #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexD10S
Copy link
Contributor

With the update of ink-node to use the latest pallet_revive version: https://github.com/use-ink/ink-node/releases/tag/v0.43.3 e2e tests are now failing due to changes in the behavior of the ReviveApi_trace_tx RPC.

Error encountered:

error on ws request `trace_tx`: User(UserError { code: 4003, message: "Client error: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed\nWASM backtrace:\nerror while executing at wasm backtrace:\n    0: 0x20b938 - ink_node_runtime.wasm!rust_begin_unwind\n    1: 0xed65 - ink_node_runtime.wasm!core::panicking::panic_fmt::hfdb65cc345fb23df\n    2: 0xd8f78 - ink_node_runtime.wasm!ReviveApi_trace_tx", data: None })

User error: Client error: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed
WASM backtrace:
error while executing at wasm backtrace:
    0: 0x20b938 - ink_node_runtime.wasm!rust_begin_unwind
    1: 0xed65 - ink_node_runtime.wasm!core::panicking::panic_fmt::hfdb65cc345fb23df
    2: 0xd8f78 - ink_node_runtime.wasm!ReviveApi_trace_tx (4003)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

How to Reproduce

To see the issue on master with ink-node v0.43.3:

export CONTRACTS_NODE="path-to-ink-node/ink-node-v0.43.3"
git checkout master
cargo contract test --all-features --manifest-path integration-tests/public/flipper/Cargo.toml --nocapture

Now with the changes of this PR :

git checkout chore/update-revive-e2e-crate 
cargo contract test --all-features --manifest-path integration-tests/public/flipper/Cargo.toml --nocapture

The tests should now pass using the same ink-node version.

Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with 0 and comparing them to ink! master:

Show Results
Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 20.807 20.807 0 0
call-runtime 2.195 2.195 0 0
combined-extension 2.51 2.51 0 0
complex-storage-structures 4.296 4.296 0 0
conditional-compilation 1.448 1.448 0 0
contract-invocation 7.935 7.936 0.001 0.0126024 📈
contract-invocation/contract1 1.844 1.844 0 0
contract-invocation/contract2 1.804 1.804 0 0
contract-invocation/virtual_contract 4.222 4.222 0 0
contract-invocation/virtual_contract_ver1 1.852 1.852 0 0
contract-invocation/virtual_contract_ver2 1.864 1.864 0 0
contract-storage 18.472 18.471 -0.001 -0.0054136 📉
contract-terminate 1.414 1.414 0 0
contract-transfer 3.036 3.036 0 0
contract-xcm 28.206 28.205 -0.001 -0.00354534 📉
cross-contract-calls 8.774 8.774 0 0
cross-contract-calls/other-contract 1.524 1.524 0 0
custom-allocator 3.012 2.977 -0.035 -1.16202 📉
custom-environment 2.23 2.23 0 0
debugging-strategies 4.086 4.086 0 0
dns 8.058 8.06 0.002 0.0248201 📈
e2e-call-runtime 1.674 1.673 -0.001 -0.0597372 📉
e2e-runtime-only-backend 2.25 2.25 0 0
erc1155 19.194 19.193 -0.001 -0.00520996 📉
erc20 9.446 9.447 0.001 0.0105865 📈
erc721 11.034 11.035 0.001 0.0090629 📈
events 5.982 5.982 0 0
flipper 1.597 1.597 0 0
incrementer 1.284 1.284 0 0
lang-err/call-builder 8.458 8.457 -0.001 -0.0118231 📉
lang-err/call-builder-delegate 3.136 3.136 0 0
lang-err/constructors-return-value 2.225 2.226 0.001 0.0449438 📈
lang-err/contract-ref 7.626 7.626 0 0
lang-err/integration-flipper 1.795 1.795 0 0
lazyvec 4.908 4.908 0 0
mapping 9.508 9.508 0 0
mother 13.622 13.622 0 0
multi-contract-caller 12.782 12.782 0 0
multi-contract-caller/accumulator 1.141 1.141 0 0
multi-contract-caller/adder 3.129 3.129 0 0
multi-contract-caller/subber 3.137 3.137 0 0
multisig 24.379 24.379 0 0
own-code-hash 2.204 2.204 0 0
payment-channel 11.014 11.014 0 0
psp22-extension 7.379 7.379 0 0
rand-extension 3.451 3.453 0.002 0.0579542 📈
runtime-call-contract 1.527 1.527 0 0
solidity-abi/events 5.248 5.248 0 0
solidity-abi/sol-cross-contract 4.907 4.907 0 0
solidity-abi/sol-cross-contract/other-contract-sol 1.634 1.634 0 0
solidity-abi/sol-encoding 1.56 1.56 0 0
solidity-abi/solidity-calls-flipper 6.253 6.253 0 0
sr25519-verification 0.957 0.957 0 0
static-buffer 2.503 2.503 0 0
storage-types 15.918 15.914 -0.004 -0.0251288 📉
trait-dyn-cross-contract-calls 3.579 3.579 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.589 1.589 0 0
trait-erc20 9.746 9.747 0.001 0.0102606 📈
trait-flipper 1.449 1.449 0 0
trait-incrementer 1.659 1.659 0 0
upgradeable-contracts/delegator 5.877 5.877 0 0
upgradeable-contracts/delegator/delegatee 2.621 2.621 0 0
upgradeable-contracts/delegator/delegatee2 2.62 2.62 0 0
upgradeable-contracts/set-code-hash 1.503 1.503 0 0
upgradeable-contracts/set-code-hash-migration 1.503 1.503 0 0
upgradeable-contracts/set-code-hash-migration/migration 1.67 1.67 0 0
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.701 1.701 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.463 1.463 0 0
wildcard-selector 2.79 2.79 0 0

Link to the run | Last update: Fri Jun 20 12:45:02 CEST 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant