Skip to content

Ignored folders not ignored (maybe windows only) #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
panda7789 opened this issue Mar 26, 2024 · 2 comments · Fixed by #1929 or #3482
Closed

Ignored folders not ignored (maybe windows only) #1928

panda7789 opened this issue Mar 26, 2024 · 2 comments · Fixed by #1929 or #3482
Labels
bug Something isn't working

Comments

@panda7789
Copy link
Contributor

I added into config this ignore settings:
image
But folder is not ignored.

I debugged it and problem is in this two lines:
image
Path is correctly normalized and \ is replaced with /.
But then relative path is made and it again contains \ instead of /.
image
@panda7789 panda7789 mentioned this issue Mar 26, 2024
Merged
@sanjai0py sanjai0py added the bug Something isn't working label Mar 26, 2024
@helloanoop helloanoop reopened this Apr 9, 2024
@vaughnbuttiw
Copy link

vaughnbuttiw commented Nov 12, 2024 •
edited
Loading

Comment moved to #2564

@Pragadesh-45 Pragadesh-45 mentioned this issue Nov 14, 2024
Merged
5 tasks
@helloanoop
Copy link
Contributor

Just merged the PR #3482
This is set to be released in v1.35.0 tomorrow

@tho-gru-38 tho-gru-38 mentioned this issue Nov 25, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@panda7789 @helloanoop @sanjai0py @vaughnbuttiw