Skip to content

fix: Folders are not ignored #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

panda7789
Copy link
Contributor

Description

fixes #1928

I have changed the order of relative and normalize operations.
Screen before:
image
Screen after:
image

Someone please test it on different environment like Linux or Mac, please.

Contribution Checklist:

  • [ x] The pull request only addresses one issue or adds one feature.
  • [ x] The pull request does not introduce any breaking changes
  • [ x] I have added screenshots or gifs to help explain the change if applicable.
  • [ x] I have read the contribution guidelines.
  • [ x] Create an issue and link to the pull request.

@helloanoop helloanoop merged commit acca798 into usebruno:main Apr 9, 2024
@helloanoop
Copy link
Contributor

Merged!

Thank you @panda7789 !

This will go out in the 1.13.0 release. Please subscribe to Discord announcement channel to stay notified on the releases.

helloanoop added a commit that referenced this pull request Apr 9, 2024
helloanoop added a commit that referenced this pull request Apr 9, 2024
@helloanoop
Copy link
Contributor

This is causing some breakages on Mac.
Another thing I notices is that node_modules does not get ignored if it is not specified.

Will come back to this PR in a couple of days.

slowjoe007 pushed a commit to slowjoe007/bruno that referenced this pull request Apr 10, 2024
slowjoe007 pushed a commit to slowjoe007/bruno that referenced this pull request Apr 10, 2024
Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Apr 13, 2024
Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Apr 13, 2024
lizziemac pushed a commit to lizziemac/bruno that referenced this pull request May 4, 2024
lizziemac pushed a commit to lizziemac/bruno that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignored folders not ignored (maybe windows only)
2 participants