Fix #1683 allow OAuth2 authorizationUrl with user provided query parameters #1712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrygamat
commented
Mar 2, 2024
Comment on lines
28
to
31
| const authorizationUrlWithQueryParams = | ||
| `${authorizationUrl}` + | ||
| (authorizationUrl.indexOf('?') > -1 ? '&' : '?') + | ||
| `client_id=${clientId}&redirect_uri=${callbackUrl}&response_type=code&scope=${scope}`; |
There was a problem hiding this comment.
Feedback on the most idiomatic syntax for this apprieciated.
|
@pietrygamat The syntax looks good. Can you resolve the conflicts? |
…ery parameters
|
Thanks for taking care of this @pietrygamat ! cc @lohxt1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases the authroization url may already contain some query parameters expected by the specific application, in which case oauth2 authorization request specific parameters should be appended to the list. Previous implementation assumed no query component in the authorization URI.
Fixes #1683
Contribution Checklist: