fix: decomment not working in json body #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request body json was not decommented if json parsing fails, which would happen if variables are not quoted. Fixes usebruno#888
|
I applied this to the git main branch (as of yesterday), and it fixed the issue with using comments and variables in the same query. I did not notice any regressions. This is one of the main blockers for us migrating from Postman, since we imported some very large collections with hundreds of queries and tests, many of which use both variables and comments. This seems to be a fairly low-risk change - would it be possible to get it merged in for the next release? |
lohxt1
approved these changes
Jun 19, 2024
5 tasks
Its-treason
added a commit
to Its-treason/bruno
that referenced
this pull request
Jun 19, 2024
This was already implemented in upstream and now improved with this usebruno#1819
jwetzell
pushed a commit
to jwetzell/bruno
that referenced
this pull request
Aug 2, 2024
Request body json was not decommented if json parsing fails, which would happen if variables are not quoted. Fixes usebruno#888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request body json was not decommented if json parsing fails, which would happen if variables are not quoted.
Fixes #888
Description
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.