feat: Add descriptions for each panel in CollectionSettings #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leftover change from when i was putzing around
lizziemac
commented
Apr 7, 2024
| <section className={`flex ${['auth', 'script', 'docs', 'clientCert'].includes(tab) ? '' : 'mt-4'}`}> | ||
| {getTabPanel(tab)} | ||
| </section> | ||
| <section className="mt-4 h-full">{getTabPanel(tab)}</section> |
There was a problem hiding this comment.
this was the key to the consistent lines placement. otherwise some required extra <br/>s etc
lizziemac
changed the title
|
Merged. Thank you @lizziemac ! This will go out in the |
Its-treason
pushed a commit
to Its-treason/bruno
that referenced
this pull request
Apr 13, 2024
…#2031) * Add descriptions for each panel in CollectionSettings * Revert index.js Leftover change from when i was putzing around
lizziemac
added a commit
to lizziemac/bruno
that referenced
this pull request
May 4, 2024
…#2031) * Add descriptions for each panel in CollectionSettings * Revert index.js Leftover change from when i was putzing around
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added descriptions to each of the panels in CollectionSettings for better user education. Furthermore, I've also made the UI more consistent across the panels. You'll notice in the provided video that the location of the description for each tab are now all on the same line, giving a smoother feeling to transitions.
Resolves #2030
Demo
Panel.Descriptions.720p.mov
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.