Skip to content

fix: resolve build issues #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

lanthoor
Copy link
Contributor

@lanthoor lanthoor commented Apr 9, 2024

Description

  • fixes for the prettier issues
  • replaces the dorny/test-reporter@v1 with a slightly better EnricoMi/publish-unit-test-result-action@v2
    • results are always visible in actions run summary
    • does not publish results on PRs from forks
    • does not require a bunch of elevated privileges

Fixes #2042.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@lanthoor lanthoor force-pushed the fix/prettier-fixes branch 2 times, most recently from 24ba91b to 3f46b43 Compare April 9, 2024 11:12
@lanthoor lanthoor force-pushed the fix/prettier-fixes branch 2 times, most recently from 7f57b33 to b900e57 Compare April 9, 2024 11:27
@lanthoor lanthoor force-pushed the fix/prettier-fixes branch from b900e57 to 30dcf70 Compare April 9, 2024 11:29
@lanthoor lanthoor changed the title chore: resolve prettier issues fix: resolve build issues Apr 9, 2024
@lanthoor
Copy link
Contributor Author

lanthoor commented Apr 9, 2024

@helloanoop I've tried to fix all the build issues. Let me know if you want some of these implemented differently.

@helloanoop helloanoop merged commit e7ff0ba into usebruno:main Apr 9, 2024
@helloanoop
Copy link
Contributor

This is great!

Thank you @lanthoor !
The PR build issues have been plauging us. Glad to have this solved.

@lanthoor lanthoor deleted the fix/prettier-fixes branch April 10, 2024 15:21
slowjoe007 pushed a commit to slowjoe007/bruno that referenced this pull request Apr 10, 2024
* fix: resolve prettier issues

* fix: allow checks write access for CLI test

* fix: use node 18 in workflows
Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Apr 13, 2024
* fix: resolve prettier issues

* fix: allow checks write access for CLI test

* fix: use node 18 in workflows
lizziemac pushed a commit to lizziemac/bruno that referenced this pull request May 4, 2024
* fix: resolve prettier issues

* fix: allow checks write access for CLI test

* fix: use node 18 in workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build is always failing
2 participants