fix: OAuth 2.0 Grant Type Authorization: "invalid_client" error / URL Encode of Client ID #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrygamat
changed the title
andreassiegel
approved these changes
Apr 26, 2024
Comment on lines
-51
to
+54
| let oauth2QueryParams = | ||
| (authorizationUrl.indexOf('?') > -1 ? '&' : '?') + `client_id=${clientId}&response_type=code`; | ||
| const authorizationUrlWithQueryParams = new URL(authorizationUrl); |
There was a problem hiding this comment.
Using the URL class to construct the request URL looks a lot cleaner than the previous string concatenation with some nested ternary operator in the middle. 👍
|
Any progress here? |
|
+1 Would like to see this merged in, getting the same error. |
pietrygamat
force-pushed
the
bugfix/2115
branch
2 times, most recently
from
30e80b4 to
bacbd04
Compare
|
@sanjai0py bumping this for you attention - please let's have this bug fixed. |
|
@lohxt1 please merge this once you have done your testing. |
lohxt1
approved these changes
Jul 26, 2024
|
Thank you, @pietrygamat, for taking the time to contribute to this PR. The next release will include your valuable fix! Also, a big thank you to @andreassiegel for taking the time to review it! |
jwetzell
pushed a commit
to jwetzell/bruno
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where OAuth2 parametrs handled by bruno were not url encoded in final request.
fixes #2115
#1003
Contribution Checklist: