fix: save button on confirm close popup not working #2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey man, you just beat me to this pull request. Will close mine. Feel free to take a look at mine about converting the body into an object to ensure it's always mutable. |
5 tasks
|
I tested this PR, it fixes the problem. |
2 tasks
|
Thanks @therealrinku ! Merged. Will be in the next outgoing release v1.16.0 |
jwetzell
pushed a commit
to jwetzell/bruno
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Save and Save all not working while there is unsaved json body fixed
resolves: #2130
Contribution Checklist:
before:
Screencast.from.2024-04-23.21-29-07.mp4
after:
Screencast.from.2024-04-23.21-29-55.mp4