improve: error handling for scripts #4082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helloanoop
previously requested changes
Mar 10, 2025
packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js
Outdated
Show resolved
Hide resolved
lohit-bruno
approved these changes
Mar 10, 2025
| } | ||
|
|
||
| // Run JSHint with predefined Bruno globals | ||
| if (!window.JSHINT(text, { |
There was a problem hiding this comment.
this could be defined as a const
const JS_LINT_OPTIONS = {
esversion: 11,
expr: true,
asi: true,
undef: true,
browser: true,
devel: true,
predef: {
'bru': false,
'req': false,
'res': false
}
}
also other keywords like test and expect need to predef
| @@ -357,7 +410,23 @@ export default class CodeEditor extends React.Component { | |||
|
|
|||
| _onEdit = () => { | |||
| if (!this.ignoreChangeEvent && this.editor) { | |||
| this.editor.setOption('lint', this.editor.getValue().trim().length > 0 ? this.lintOptions : false); | |||
| if (this.props.mode === 'javascript') { | |||
There was a problem hiding this comment.
the lint options could be defined once in the constructor based on mode and used everywhere
| @@ -731,38 +766,38 @@ const registerNetworkIpc = (mainWindow) => { | |||
|
|
|||
| const testFile = get(request, 'tests'); | |||
| if (typeof testFile === 'string') { | |||
| const testRuntime = new TestRuntime({ runtime: scriptingConfig?.runtime }); | |||
There was a problem hiding this comment.
nothing got modified here except indentation ?
| ); | ||
| } catch (error) { | ||
| console.error('Post-response script error:', error); | ||
| postResponseError = serializeError(error); |
There was a problem hiding this comment.
could be a new different event like request-post-script-error or something
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved Error Handling for Request Scripts
What Changed
scriptErrorsfield in the response object to track both post-response error