Skip to content

[DX]: Document running test suite for all workspaces #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

pieterocp
Copy link
Contributor

Description

As a developer who hasn't worked on many npm projects using workspaces, I wasn't aware how npm has the ability to run a command over all the workspaces . This means with this one-liner, a developer can easily run nearly all of the test suites in one go.

So off the back of this, this PR changes the contributing documentation slightly to make it clearer it's possible to run the tests over the whole project rather than having to run them one by one.

Note, once I get a thumbs up emoji/an affirmative comment that is a welcomed change, then I'll make the change to all the different languages using auto-translation tools to amend the # run tests over all workspaces comments into respective languages.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

todo, add to all other languages contributing guides
@helloanoop
Copy link
Contributor

Looks good. @pieterocp !

@pieterocp
Copy link
Contributor Author

Thanks, feel free to slap an approval and merge it whenever.

@pieterocp pieterocp force-pushed the add-all-test-to-contributing branch from 4e6f14d to 0ddb715 Compare February 27, 2025 22:34
@pieterocp
Copy link
Contributor Author

Put in machine translations, for the 3 languages I do know it's decent enough, for the others, complete shot in the dark.

@pieterocp
Copy link
Contributor Author

pieterocp commented Mar 14, 2025

Good afternoon @helloanoop , hope you're having a lovely day. Added in machine translations for the contributing docs, can only speak 2 of the languages (dutch and german), so one for the discord to get other languages checked since it might be wildly off? Probably worth checking with some native speakers to be sure since otherwise it's potentially 16 PRs later.

@helloanoop helloanoop merged commit ccb951d into usebruno:main Mar 14, 2025
2 checks passed
@helloanoop
Copy link
Contributor

Thank you @pieterocp !
Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants