fix: lint errors for atob/btoa redefinition #4509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks @pooja-bruno ! |
jonman5
pushed a commit
to jonman5/bruno
that referenced
this pull request
Apr 15, 2025
This reverts commit 54a03fd.
pooja-bruno
added a commit
to pooja-bruno/bruno
that referenced
this pull request
May 7, 2025
* fix: lint errors for atob/btoa redefinition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the JSHint lint errors (W079) that appear when using
const atob = require("atob")orconst btoa = require("btoa")in the editor. These errors occur because atob and btoa are built-in browser functions, but users sometimes need to explicitly require them in Node.js environments.The solution filters out these specific redefinition warnings while preserving other lint checks, improving the developer experience when working with Base64 encoding/decoding functions.
Contribution Checklist: