Skip to content

Bugfix: Add cheerio and xml2js modules to post-response scripts #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andreas-wirth
Copy link
Contributor

@andreas-wirth andreas-wirth commented Apr 15, 2025

Description

Addresses #4515: #3976 introduced cheerio and xml2js modules to be used within scripts and tests. Unfortunately they forgot to add the modules to the post-response script runtime, so it is not available there.
This PR adds these modules + expands the existing tests

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 16, 2025
@helloanoop helloanoop merged commit 9a21eec into usebruno:main Apr 16, 2025
3 of 4 checks passed
@helloanoop
Copy link
Contributor

Merged. Thanks @andreas-wirth !

pooja-bruno pushed a commit to pooja-bruno/bruno that referenced this pull request May 7, 2025
…runo#4516)

* Bugfix: Add cheerio and xml2js modules to post-response scripts
* chore: improved cheerio and xml2js test
---------

Co-authored-by: Anoop M D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants