Create/Import collection UX improvements #4540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow editing the input path where previously the `<input>` is marked `readonly`. Also this will allow automating test using Playwright.
- Added a util for formatting the error form IPC - Updated Toast global styles to prevent text overflow. Whenever long file paths are shown, it overflows the Toast container.
ramki-bruno
force-pushed
the
feat/create-import-collection-improvements
branch
from
c8db572 to
228d73c
Compare
ramki-bruno
requested review from
helloanoop,
Pragadesh-45,
sanjaikumar-bruno,
Pragadesh44-Bruno and
lohit-bruno
and removed request for
Pragadesh-45
helloanoop
reviewed
Apr 22, 2025
| @@ -113,14 +115,16 @@ const CreateCollection = ({ onClose }) => { | |||
| id="collection-location" | |||
| type="text" | |||
| name="collectionLocation" | |||
There was a problem hiding this comment.
I am not sure we need to remove readonly.
If its just for the playwright tests to work, we could conditionally allow editing location based on a env var that gets injected at runtime.
There was a problem hiding this comment.
IMO, it does improve the UX
any reason it should not be editable?
pooja-bruno
pushed a commit
to pooja-bruno/bruno
that referenced
this pull request
May 20, 2025
* Fix: Improve UX for selecting location when create/import collection Allow editing the input path where previously the `<input>` is marked `readonly`. Also this will allow automating test using Playwright. * Fix: Import-collection select-location Modal closes on error * Improved error-toast for creating and importing collections - Added a util for formatting the error form IPC - Updated Toast global styles to prevent text overflow. Whenever long file paths are shown, it overflows the Toast container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever long file paths are shown, it overflows the Toast container.
<input>is markedreadonly.Also this will allow automating test using Playwright.