No specific UI feedback on "Display name" missing while creating a new user, except for save button being disabled

[rowasc]

Expected behaviour

• I see an error/warning letting me know that I have to fill in the display name.
• Error text: "Display name is required" (ie: like all other required fields)

It should look like this:

Actual behaviour

I don't see an error or warning unless I edit the display name field and delete the content.

Steps to reproduce the behaviour/error

• Login as an admin
• Go to settings/users
• Click on + to add a user.
• Fill in email and password.
• • The save button is disabled, but I don't know why.

Aha! Link: https://ushahiditeam.aha.io/features/PROD-515

[rowasc]

Not a blocker, but it's really confusing if you don't realize the display name is there and required.

[rowasc]

cc @jshorland probably low priority considering all things, but still a weird behavior, I think

[NidhiKJha]

@Angamanga This issue appears to have been fixed.
It issue should be closed.

[rowasc]

Thanks, @NidhiKJha for checking this :)
I think this is only fixed in the JS rewrite branches. Sadly It's still happening in master (production) so it needs to remain open

[Erioldoesdesign]

Would love to see this in prod :)

[rowasc]

This issue is still open to be fixed (noting for future contributors) . thanks 🎉

[noone0212]

Hello @rowasc , Can I work on this issue? Will be my first bug to work upon!
Also what files should I see to get started with solving the issue?

[rowasc]

Hi, thanks for reaching out. Yes you can totally work on this , thank you so much.

• The code for the user settings section can be found in ./app/settings/users
  You may want to look at the users-edit file in that dir for this specific issue. I think probably the best solution is that if the form itself is dirty/has changed and that field is empty, we indicate that field (name) is missing. The way it works right now the user is totally stuck without any clue of what's happening 😬

Another thing that would be useful is showing an asterisk for required fields as we do for posts.

cc @Angamanga FYI

[rowasc]

@Obadha2 this needs QA (in steve)
Thanks!

[AmTryingMyBest]

@rowasc while all required fields are highlighted, there's no feedback if "Display Name" is missing. There's no response when user clicks Save.
Doesn't pass QA.

[Angamanga]

@rowasc @Obadha2 This one is a bit tricky:

1. All the fields are required in order to activate the save-button.
2. When adding a new user, the display-name is empty
3. The validation only check touched fields, since we don't want to show an ugly error-label before the user starts typing
   So if the user doesn't add anything to display-name, the label cannot be seen. If the user adds something and then deletes it, THEN the error-label is shown.

This fix is a good start since it at least shows an asterisk on the required fields. We could add a new issue about activating/disabling the save-button (probably happens in more places too). We really want to move away from that anyway since its not accessible 🎉.

[rowasc]

alright. Then I think this improvement can go live, and we need to work on a more accessible solution as a second step, as Anna mentions. I think disabling the button is not the best idea without providing feedback.

EDIT: let's leave this one open actually, it contains all the history (even if we release the current fix) and covers what we are discussing no?

[Angamanga]

@rowasc Yes, lets keep it open, I will take a look at and spec it further today!