2105 display name #1486
Merged
2105 display name #1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rowasc This is ready for review! |
|
@rowasc Could you review this one please? |
rowasc
reviewed
Oct 10, 2020
| @@ -30,44 +30,50 @@ function ( | |||
| $rootScope.$emit('setPageTitle', title); | |||
| }); | |||
|
|
|||
| $scope.isValid = true; | |||
There was a problem hiding this comment.
shouldn't isValid start assuming false? Just a question since I'm not sure if the repercusion is that it'll be weird in the UX if we change it
| UserEndpoint.saveCache(user).$promise.then(function (response) { | ||
| if (response.id) { | ||
| Notify.notify('notify.user.save_success', {name: user.realname}); | ||
| $scope.saving_user = false; |
There was a problem hiding this comment.
I think we could do savingUser instead to keep it similar to the others (userSaveUser etc)
|
@rowasc Have fixed above comments so this is ready for re-review 🎉 |
rowasc
approved these changes
Oct 20, 2020
|
QA's, passes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Testing checklist:
-Go to settings->users
Click on a random user
Empty one or many of the input-fields
You should see error labels connected to those fields
Click on save
The button should not be disabled
You should stay on the page
Error-labels where information is missing should be visible
Add information in the boxes
Click on save
The button should not be disabled
You should get redirected to the users-list
The information you changed should be saved
I certify that I ran my checklist
Fixes ushahidi/platform#2105 .
Ping @ushahidi/platform