Skip to content

Settings => General page - not all fields show a validation error when they are invalid #3304

Closed
ushahidi/platform-client
#1423
@rowasc

Description

@rowasc

Describe the bug
Some fields like Contact Email Address and default lat/lon values do not show anything to the user if they have invalid values. This is confusing and prevents the user from saving the page until they solve the issue, but they don't have feedback about what's wrong.

Where was the bug observed

  • Development branch (locally)
  • Community support channel where a user reported that they cannot save the settings

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings -> General
  2. In the Contact Email Address field, write an invalid email like hello
  3. You won't see any error messages and the save button will be disabled.

Expected behavior

  1. Go to Settings -> General
  2. In the Contact Email Address field, write an invalid email like hello
  3. You see a validation error message for the field
  4. The save button is disabled until the error is fixed

Is there a workaround? What is it.
Just fixing the errors, but since the user doesn't know the validation rules this might be confusing/tricky to do.

Screenshots
screen shot 2018-09-27 at 2 57 33 pm

Implementation Notes

Want to work on this issue?🙋

Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

Metadata

Metadata

Assignees

Labels

BugCodebase: ClientIndicates issue work will be in clientCommunity TaskIssues that the Ushahidi OSS community is encouraged to contribute toHacktoberfestIssues open to folks participating in hacktoberfestTheme: Formsgood-first-issueIssues that are ideal for first time contributors to OSS or first time contributing to the platform

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions