Skip to content

Data sources - "tweets" is always used to describe the content for the "Import to survey" field #3531

Closed
ushahidi/platform-client
#1426
@Erioldoesdesign

Description

@Erioldoesdesign

Describe the bug
When setting up data sources, the data source type is hardcoded and is always "tweets" instead of the correct data source type.

Where was the bug observed
Personal test deployment: https://lgbthistoryswuk.ushahidi.io/views/map

To Reproduce
Steps to reproduce the behavior:

  1. Go to a deployment you have admin access to
  2. Log in as 'an admin'
  3. Click on 'settings'
  4. Scroll down to 'data sources'
  5. Choose 'email', or any of the SMS data sources
  6. Toggle on 'Accept survey submissions from this source'
  7. Toggle on 'Import to survey'
  8. In the text that says 'Choose what should be assigned to each survey field
    Each of the survey's fields are listed below. Choose the data from your tweets that you'd like to use to populate each of those fields.'

Expected behavior
The data source type shown in the description should match the one the user is looking at.
It should read

  • For the Twitter data source: Each of the survey's fields are listed below. Choose the data from Twitter that you'd like to use to populate each of those fields.'
  • For the Email data source: Each of the survey's fields are listed below. Choose the data from Email that you'd like to use to populate each of those fields.'
    .. etc ...

Is there a workaround? What is it.
No

Screenshots

Screenshot 2019-05-07 at 12 45 22

URL / Environment where this happened
Any ushahidi.io or testing environment with Ushahidi V3 or V4

Desktop Hardware Details (please complete the following information):

  • Applies to any OS
  • Applies to any browser

Working on this issue

Implementation notes

Changes required (first timers only)

  • in the en.json file, look for the key "choose_survey_field_desc" and replace its value with
"Each of the survey's fields are listed below. Choose the data from {{datasource_type}} that you'd like to use to populate each of those fields.",
  • in the datasources.html file, look for the p with the translation key "survey.choose_survey_field_desc" and replace that

    with

<p translate-values="{datasource_type: provider.name}" translate="survey.choose_survey_field_desc">Each of the survey's fields are listed below. Choose the data from your tweets that you'd like to use to populate each of those fields.</p>

Ping @rowasc if you need help with this issue!

Metadata

Metadata

Assignees

Labels

BugCodebase: ClientIndicates issue work will be in clientCommunity TaskIssues that the Ushahidi OSS community is encouraged to contribute toHacktoberfestIssues open to folks participating in hacktoberfestTheme: Data Providersfirst-timers-onlyI’m willing to hold your hand so you can make your first PR. This issue is a bit easier than normal.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions