-
Notifications
You must be signed in to change notification settings - Fork 509
fix(Twitter): urls are now formatted correctly for posts and messages #3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An overcomplicated way to say "hey please update the messages when they match the posts and are twee=ts"
come on little pull request you can do it. Anyway, this passes for me locally. Tested up/down migration |
disable phpcs for up/down because it ironically hurts readability (more!) to cut the lines even more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Obadha2 please check. thanks! |
@rowasc this still fails QA. It seems the merge undid previous changes. New tweets coming in have the link now looking like: |
@Obadha2 that's odd, maybe something with steve 🤔 Will check what's up with the server since it passed everything locally . |
agh I got it, it's becuase I forgot to revert your revert , so develop doesn't have the code for it |
Using the format https://twitter.com/{userid}/status/{tweetId}
This pull request makes the following changes:
Test checklist
BEFORE you merge this PR, ensure that you
After you merge this PR and it lands in steve
Check some old tweets and verify the links work now
Get new tweets from the twitter datasource, the links should work
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform