cat: bugfix when running with -T option #7636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlmcdowall
commented
Apr 2, 2025
| @@ -644,7 +644,7 @@ fn write_tab_to_end<W: Write>(mut in_buf: &[u8], writer: &mut W) -> usize { | |||
| } | |||
| None => { | |||
| writer.write_all(in_buf).unwrap(); | |||
| return in_buf.len(); | |||
| return in_buf.len() + count; | |||
There was a problem hiding this comment.
Line 638 above moves the in_buf slice along the original input in_buf. If the function later returns because no \r or \n characters were found (i.e. we match to line 645) then we would return just the size of the final slice, when in fact we should be returning the size of the entire buffer.
karlmcdowall
force-pushed
the
cat_find_a_bug_fix_a_bug
branch
from
6d75472 to
cb3ac65
Compare
|
GNU testsuite comparison: |
Fixes an crash seen when running with -T option if no newline is found in a buffer. Added unit test to validate.
karlmcdowall
force-pushed
the
cat_find_a_bug_fix_a_bug
branch
from
cb3ac65 to
a4b621a
Compare
|
GNU testsuite comparison: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7637
Fixes an crash seen when running with -T option if no newline is found in a buffer.
Added unit test to validate.