cat: Formatting performance improvement #7642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some examples of performance gains...
|
karlmcdowall
force-pushed
the
cat_write_to_end_perf
branch
from
76708e3 to
cea1634
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Apr 4, 2025
|
Impressive! |
|
GNU testsuite comparison: |
Use memchr library in `cat` to improve performance when detecting newlines. Significantly improves performance when running with -n, -s, -E, -b flags.
Co-authored-by: Sylvestre Ledru <[email protected]>
karlmcdowall
force-pushed
the
cat_write_to_end_perf
branch
from
a8acb54 to
464d172
Compare
|
GNU testsuite comparison: |
eduardorittner
pushed a commit
to eduardorittner/coreutils
that referenced
this pull request
Apr 4, 2025
* cat: Formatting performance improvement Use memchr library in `cat` to improve performance when detecting newlines. Significantly improves performance when running with -n, -s, -E, -b flags. Co-authored-by: Sylvestre Ledru <[email protected]> --------- Co-authored-by: Sylvestre Ledru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use memchr library in
catto improve performance when detecting newlines.Significantly improves performance when running with -n, -s, -E, -b flags.