Skip to content

Consolidate crate config in workspace #7710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 9, 2025

Make all common data like version, edition, license, ... be managed in one central workspace. This makes management much simpler

@nyurik nyurik force-pushed the workspaces branch 2 times, most recently from ddf8bb5 to 4fcebd6 Compare April 9, 2025 08:02
Copy link

github-actions bot commented Apr 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

Copy link

github-actions bot commented Apr 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

categories = ["command-line-utilities"]
edition = "2024"

version.workspace = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, TIL!

@sylvestre
Copy link
Contributor

Could you please force push or rebase? Seems that we hit a github bug

@nyurik
Copy link
Contributor Author

nyurik commented Apr 10, 2025

will do in a sec

Make all common data like version, edition, license, ... be managed in one central workspace. This makes management much simpler
@nyurik
Copy link
Contributor Author

nyurik commented Apr 10, 2025

@sylvestre done, let me know if you need anything else. I also pushed a squash commit in another PR. BTW, you can always use squash and merge - i think it is much cleaner way to keep readable history. Also, you can enforce it via github rulesets - there is a "keep linear history" there, plus you can disable all other merge methods.

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit 1bfe656 into uutils:main Apr 10, 2025
69 checks passed
@nyurik nyurik deleted the workspaces branch April 10, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants