Skip to content

chore: fix ref_option lint #7724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025
Merged

chore: fix ref_option lint #7724

merged 1 commit into from
Apr 12, 2025

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 11, 2025

Resolve ref_option lint. Also, I optimized is_first_filename_timestamp a bit to make it faster and more streamlined. In some cases, I replaced &Option<T> with Option<T> instead of a reference when T was copyable.

p.s. disclaimer: I'm the author of that lint

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

Resolve [ref_option](https://rust-lang.github.io/rust-clippy/master/index.html#ref_option) lint.  Also, I optimized `is_first_filename_timestamp` a bit to make it faster and more streamlined.

p.s. disclaimer: I'm the author of that lint
@sylvestre sylvestre merged commit e4c7bd0 into uutils:main Apr 12, 2025
69 checks passed
@nyurik nyurik deleted the ref-option branch April 12, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants