Skip to content

refactor(tests): use absolute difference of dates to check if they are within a window #7755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

lavafroth
Copy link
Contributor

Changes

  • Converts the resultant date to UTC.
  • Takes the absolute difference of the result and the expected value.
  • Checks if this value is less than (within) a window.

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

could you please explain why this change is needed? sorry it isn't clear to me :)

@lavafroth
Copy link
Contributor Author

lavafroth commented Apr 14, 2025 via email

@sylvestre
Copy link
Contributor

ok, code simplification then :)
thanks

@sylvestre sylvestre merged commit 131ee87 into uutils:main Apr 14, 2025
106 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants