mknod: implement selinux support #7818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
force-pushed
the
selinux-mknod
branch
5 times, most recently
from
22e75a9 to
a528e41
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 22, 2025
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 22, 2025
cakebaker
reviewed
Apr 22, 2025
sylvestre
force-pushed
the
selinux-mknod
branch
2 times, most recently
from
09b1414 to
36c40b7
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 23, 2025
| .long(options::CONTEXT) | ||
| .value_name("CTX") | ||
| .value_parser(value_parser!(String)) | ||
| .num_args(0..=1) |
There was a problem hiding this comment.
You also have to specify require_equals, otherwise something like cargo run --features=unix,feat_selinux mknod --context hello_world p will fail.
Suggested change
| .num_args(0..=1) | |
| .num_args(0..=1) | |
| .require_equals(true) |
+ improve the option management a bit
sylvestre
force-pushed
the
selinux-mknod
branch
from
36c40b7 to
c9babe4
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and improve the option management a bit