-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
selinux: start the support of install #7908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4237d36
to
71e3c19
Compare
GNU testsuite comparison:
|
Congrats! The gnu test tests/install/install-C-selinux is no longer failing! Oh, this is unexpected :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces initial support for SELinux in the install utility by implementing features to preserve and set security contexts during file installation. The key changes include:
- Adding tests for SELinux functionality and updating spell-check hints in the test suite.
- Implementing new SELinux-related functions (contexts_differ and preserve_security_context) in the uucore library.
- Updating the install command to support new flags (-P for preserving context and -Z for setting context) and integrating SELinux functionality into the file copy process.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/by-util/test_install.rs | Updated spell-check hints, removed unimplemented test, added new SELinux tests. |
src/uucore/src/lib/features/selinux.rs | Added functions for comparing and preserving SELinux contexts. |
src/uu/install/src/install.rs | Integrated SELinux support into install behavior and file operations. |
src/uu/install/Cargo.toml | Added selinux feature dependency for install. |
Cargo.toml | Added selinux feature activation for install. |
Comments suppressed due to low confidence (1)
tests/by-util/test_install.rs:2017
- Verify if the substring 'ailed to set default file creation' is intentional or if it should be corrected to 'failed to set default file creation' to improve clarity.
.stderr_contains("ailed to set default file creation");
71e3c19
to
71d79e6
Compare
GNU testsuite comparison:
|
71d79e6
to
baee8d7
Compare
GNU testsuite comparison:
|
e25df00
to
2127de5
Compare
GNU testsuite comparison:
|
2127de5
to
38861cc
Compare
GNU testsuite comparison:
|
Great, good work :) |
No description provided.