-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
expr: Fix parsing regex anchors '^' and '$' #7953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The |
The clippy errors are already reported by #7945 |
GNU testsuite comparison:
|
c44d228
to
3f9a5f3
Compare
GNU testsuite comparison:
|
GNU testsuite comparison:
|
GNU testsuite comparison:
|
Thanks ! The changes look good to me 👍 Lastly, can you squash your commits in only 2-3 ? I can squash them all in 1 and merge, but I find it interesting to have 1 commit for |
Enable fixed test `test_bre11`
5d88d56
to
2933286
Compare
@RenjiSann, please check now. |
GNU testsuite comparison:
|
Thank you for your contribution ! 🚀 |
This PR handles and tests the cases where '^' or '$' should be interpreted as special characters.
Reference: https://www.gnu.org/software/sed/manual/html_node/BRE-syntax.html
fixes #7951, fixes #7952