Skip to content

fix(providers): always use optional instead of mix of nullish for providerOptions #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025

Conversation

samdenty
Copy link
Contributor

@samdenty samdenty commented May 2, 2025

Background

We were using nullish in some places (due to AI autocompletion)

Summary

Now it's unified to use .optional() everywhere

Verification

Checked JSDoc to make sure we're not breaking anything

Tasks

  • Tests have been added / updated (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • A patch changeset for relevant packages has been added (for bug fixes / features - run pnpm changeset in the project root)
  • Formatting issues have been fixed (run pnpm prettier-fix in the project root)

Future Work

Related Issues

@samdenty samdenty merged commit 6f231db into v5 May 3, 2025
8 checks passed
@samdenty samdenty deleted the v5-unify-providerOptions2 branch May 3, 2025 10:20
samdenty added a commit that referenced this pull request May 5, 2025
* origin/v5: (23 commits)
  chore (ai): remove StreamData and mergeStreams (#6150)
  chore (build): fix typecheck setup (#6151)
  chore (ai): remove IdGenerator duplication (#6147)
  chore (ai): remove content from ui messages (#6145)
  Version Packages (canary) (#6115)
  feat (provider): support reasoning tokens, cached input tokens, total token in usage information (#6140)
  test (ai): use `mock-provider` instead of `openai` to match used `MockImageModelV2` (#6132)
  fix(providers): always use optional instead of mix of nullish for providerOptions (#6122)
  chore (ai): remove sendExtraMessageFields (#6120)
  chore(provider-utils): move ToolResultContent to provider-utils (#6121)
  feat(embed-many): respect supportsParallelCalls & concurrency (#6108)
  chore (provider-utils): return IdGenerator interface (#6118)
  chore (provider): improve jsdoc comments (#6117)
  chore (ai): remove outdated typecasts (#6116)
  chore (ai): remove useChat keepLastMessageOnError (#6114)
  fix(providers/openai): logprobs for stream alongside completion model (#6091)
  chore (ai): move maxSteps into UseChatOptions (#6113)
  docs (ai): add notes on schema .optional() (#6111)
  chore: update references to use ai-sdk.dev (#6076) (#6107)
  Version Packages (canary) (#6069)
  ...
iteratetograceness pushed a commit to iteratetograceness/ai that referenced this pull request May 9, 2025
…viderOptions (vercel#6122)

## Background

We were using nullish in some places (due to AI autocompletion)

## Summary

Now it's unified to use `.optional()` everywhere

## Verification

Checked JSDoc to make sure we're not breaking anything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants