DATA-2715: Change collector additional params to take in any instead of only strings #5058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
gloriacai01
reviewed
Jun 23, 2025
| if err := mimeType.UnmarshalTo(mimeStr); err != nil { | ||
| return nil, err | ||
| var mimeStr string | ||
| // Try to unmarshal as StringValue first |
There was a problem hiding this comment.
lets add a comment about why we're unmarshaling as string first and then as value
| @@ -70,9 +70,23 @@ func convertStringToAnyPB(str string) (*anypb.Any, error) { | |||
| return anyVal, nil | |||
| } | |||
|
|
|||
| func convertMapToAnyPBMap(params map[string]interface{}) (map[string]*anypb.Any, error) { | |||
| methodParams := map[string]*anypb.Any{} | |||
There was a problem hiding this comment.
question for my own understanding: why did we create this new function? is it different than the existing one we have?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified all usages of additionalParams to use map[string]interface{} rather than map[string]string
edited all local tests as well