Skip to content

docs: refactor components to TypeScript #20075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 22, 2025
Merged

docs: refactor components to TypeScript #20075

merged 5 commits into from
May 22, 2025

Conversation

wChenonly
Copy link
Contributor

Description

fix
image

@wChenonly wChenonly changed the title chroe: added TypeScript support in YouTubeVideovue chore: added TypeScript support in YouTubeVideovue May 21, 2025
@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 21, 2025
@sapphi-red
Copy link
Member

Would you add lang=ts to all the components so that it's consistent? I'm also fine with adding "allowJs": true in docs/.vitepress/tsconfig.json if that's easier.

@wChenonly
Copy link
Contributor Author

Would you add lang=ts to all the components so that it's consistent? I'm also fine with adding "allowJs": true in docs/.vitepress/tsconfig.json if that's easier.

Let me add lang=ts to ensure consistency.

@wChenonly
Copy link
Contributor Author

done

@sapphi-red sapphi-red changed the title chore: added TypeScript support in YouTubeVideovue docs: refactor components to TypeScript May 22, 2025
sapphi-red
sapphi-red approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sapphi-red sapphi-red merged commit 1a660a9 into vitejs:main May 22, 2025
11 checks passed
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
@wChenonly @moonlitusun
docs: refactor components to TypeScript (vitejs#20075)
776ddbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wChenonly @sapphi-red