Skip to content

docs: fix gitlab pages deploy syntax #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021
Merged

docs: fix gitlab pages deploy syntax #5909

merged 1 commit into from
Nov 30, 2021

Conversation

jonthesquirrel
Copy link
Contributor

Description

The GitLab Pages example causes GitLab CI to fail due to invalid syntax:
Screen Shot 2021-11-30 at 8 33 26 AM

Here is the documentation about the syntax: https://docs.gitlab.com/ee/ci/yaml/index.html#rules

This PR fixes the syntax.

Additional context

This change has been tested to work on GItLab CI.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

docs: fix gitlab pages deploy syntax

Fix GitLab CI build failure due to invalid syntax.
@bluwy bluwy added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) labels Nov 30, 2021
@patak-dev patak-dev merged commit 4bc9483 into vitejs:main Nov 30, 2021
@patak-dev
Copy link
Member

Thanks @jonthesquirrel, you may also want to check if the instructions for https://vitepress.vuejs.org/guide/deploy.html#gitlab-pages-and-gitlab-ci are correct in case you would like to also improve the VitePress docs. I see there isn't a conditional there, but maybe there should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants